feat(website): profile pictures

lennartkloock commented 8 months ago

Proposed changes

This pr implements website support for profile pictures.

Including:

Displaying and subscribing to changes
Uploading profile pictures
Removing profile pictures

Types of changes

What types of changes does your code introduce to Scuffle? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments

IS2511 commented 8 months ago

The slash in parenthesis of the commit message is for sure not to format. Please choose one or remove the parenthesis entirely if the scope is global.

lennartkloock commented 8 months ago

The slash in parenthesis of the commit message is for sure not to format. Please choose one or remove the parenthesis entirely if the scope is global.

Because this is a mono repo the scope is not global most of the time. What scope would you suggest for platform/website or platform/api?

Edit: I can't just write api because we have a video api and a platform api. And I can't just write platform because we have platform website and platform api

IS2511 commented 8 months ago

@lennartkloock Hmm, I've googled around a bit and it looks like dashes are generally uhhh ok, probably.

Conventional Commits is strongly against anything but a single word:

A scope MAY be provided after a type. A scope MUST consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser):

Karma Style is indifferent:

Example <scope> values:

web-server

I personally like the slash, it clearly conveys the intent - "part of" or a "subdirectory", instead of just "component name". A dash is a compromise I'm willing to accept (e.g. platform-api).

On a related note, I think the prefix of the commit message is getting too long with that subject name ij general. Maybe we should name the components somehow and use that shorter name? How about shortening website to web? Not much help though... Still, shorter is better in this case IMO.

IS2511 commented 8 months ago

I just noticed the image_processor commits. Not sure how I feel about that underscore... Probably negatively. If those will be squashed anyway then it doesn't matter much.

lennartkloock commented 8 months ago

@IS2511 I'll just leave out platform/ or video/ in the future. I guess that's enough because apart from api all components have unique names anyway

codecov[bot] commented 8 months ago

Codecov Report

Attention: 277 lines in your changes are missing coverage. Please review.

Comparison is base (cf18151) 46.71% compared to head (420707a) 46.44%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/website #186 +/- ## =================================================== - Coverage 46.71% 46.44% -0.27% =================================================== Files 486 486 Lines 30831 31035 +204 =================================================== + Hits 14402 14415 +13 - Misses 16429 16620 +191 ``` | [Files](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV) | Coverage Δ | | |---|---|---| | [ffmpeg/src/scalar.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-ZmZtcGVnL3NyYy9zY2FsYXIucnM=) | `89.36% <100.00%> (ø)` | | | [platform/api/src/api/v1/gql/subscription/chat.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vYXBpL3NyYy9hcGkvdjEvZ3FsL3N1YnNjcmlwdGlvbi9jaGF0LnJz) | `0.00% <ø> (ø)` | | | [video/api/src/api/events/ack.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-dmlkZW8vYXBpL3NyYy9hcGkvZXZlbnRzL2Fjay5ycw==) | `58.69% <100.00%> (ø)` | | | [platform/api/src/api/v1/gql/subscription/mod.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vYXBpL3NyYy9hcGkvdjEvZ3FsL3N1YnNjcmlwdGlvbi9tb2QucnM=) | `0.00% <0.00%> (ø)` | | | [platform/api/src/api/v1/gql/subscription/user.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vYXBpL3NyYy9hcGkvdjEvZ3FsL3N1YnNjcmlwdGlvbi91c2VyLnJz) | `0.00% <0.00%> (ø)` | | | [platform/api/src/subscription.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vYXBpL3NyYy9zdWJzY3JpcHRpb24ucnM=) | `0.00% <0.00%> (ø)` | | | [platform/api/src/api/v1/gql/models/image\_upload.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vYXBpL3NyYy9hcGkvdjEvZ3FsL21vZGVscy9pbWFnZV91cGxvYWQucnM=) | `0.00% <0.00%> (ø)` | | | [platform/api/src/api/v1/gql/models/user.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vYXBpL3NyYy9hcGkvdjEvZ3FsL21vZGVscy91c2VyLnJz) | `0.00% <0.00%> (ø)` | | | [platform/api/src/api/v1/upload/mod.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vYXBpL3NyYy9hcGkvdjEvdXBsb2FkL21vZC5ycw==) | `0.00% <0.00%> (ø)` | | | [platform/api/src/config.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vYXBpL3NyYy9jb25maWcucnM=) | `0.00% <0.00%> (ø)` | | | ... and [9 more](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/186/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV)

ScuffleTV / scuffle