ScuffleTV / scuffle

Live streaming platform
https://scuffle.tv
255 stars 26 forks source link

feat(platform/image-processor): allow http downloads on image processor #188

Closed TroyKomodo closed 10 months ago

TroyKomodo commented 10 months ago

Proposed changes

Allow for the input path to be an http url which the image processor will fetch when processing the image.

Types of changes

What types of changes does your code introduce to Scuffle? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (52ac456) 46.72% compared to head (4784778) 46.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/website #188 +/- ## =================================================== - Coverage 46.72% 46.70% -0.02% =================================================== Files 486 486 Lines 30818 30831 +13 =================================================== + Hits 14399 14401 +2 - Misses 16419 16430 +11 ``` | [Files](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV) | Coverage Δ | | |---|---|---| | [common/src/task.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-Y29tbW9uL3NyYy90YXNrLnJz) | `79.16% <100.00%> (+0.12%)` | :arrow_up: | | [platform/image\_processor/src/processor/error.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vaW1hZ2VfcHJvY2Vzc29yL3NyYy9wcm9jZXNzb3IvZXJyb3IucnM=) | `0.00% <ø> (ø)` | | | [...mage\_processor/src/processor/job/decoder/ffmpeg.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vaW1hZ2VfcHJvY2Vzc29yL3NyYy9wcm9jZXNzb3Ivam9iL2RlY29kZXIvZmZtcGVnLnJz) | `82.85% <100.00%> (+0.12%)` | :arrow_up: | | [platform/image\_processor/src/config.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vaW1hZ2VfcHJvY2Vzc29yL3NyYy9jb25maWcucnM=) | `0.00% <0.00%> (ø)` | | | [platform/image\_processor/src/processor/job/mod.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vaW1hZ2VfcHJvY2Vzc29yL3NyYy9wcm9jZXNzb3Ivam9iL21vZC5ycw==) | `0.00% <0.00%> (ø)` | |