ScuffleTV / scuffle

Live streaming platform
https://scuffle.tv
232 stars 26 forks source link

feat: remove sqlx #192

Closed TroyKomodo closed 8 months ago

TroyKomodo commented 8 months ago

Proposed changes

Remove SQLx in favor of tokio-postgres. SQLx has had many issues. From the poor design of the query engine to issues with transcations and deserializing. The idea of compile time queries is pretty good but the SQLx implementation is just very sub par. Most features are not supported.

Types of changes

What types of changes does your code introduce to Scuffle? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

-/-

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1086 lines in your changes are missing coverage. Please review.

Comparison is base (52ac456) 46.72% compared to head (b1d83d6) 46.50%. Report is 6 commits behind head on feature/website.

:exclamation: Current head b1d83d6 differs from pull request most recent head 17ee76f. Consider uploading reports for the commit 17ee76f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/website #192 +/- ## =================================================== - Coverage 46.72% 46.50% -0.22% =================================================== Files 486 486 Lines 30818 31392 +574 =================================================== + Hits 14399 14599 +200 - Misses 16419 16793 +374 ``` | [Files](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV) | Coverage Δ | | |---|---|---| | [common/src/dataloader/mod.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-Y29tbW9uL3NyYy9kYXRhbG9hZGVyL21vZC5ycw==) | `95.20% <100.00%> (ø)` | | | [common/src/global.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-Y29tbW9uL3NyYy9nbG9iYWwucnM=) | `100.00% <ø> (ø)` | | | [common/src/task.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-Y29tbW9uL3NyYy90YXNrLnJz) | `79.16% <100.00%> (+0.12%)` | :arrow_up: | | [platform/image\_processor/src/database.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vaW1hZ2VfcHJvY2Vzc29yL3NyYy9kYXRhYmFzZS5ycw==) | `100.00% <100.00%> (ø)` | | | [platform/image\_processor/src/processor/mod.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-cGxhdGZvcm0vaW1hZ2VfcHJvY2Vzc29yL3NyYy9wcm9jZXNzb3IvbW9kLnJz) | `0.00% <ø> (ø)` | | | [video/api/src/api/access\_token/create.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-dmlkZW8vYXBpL3NyYy9hcGkvYWNjZXNzX3Rva2VuL2NyZWF0ZS5ycw==) | `90.00% <100.00%> (-0.33%)` | :arrow_down: | | [video/api/src/api/access\_token/delete.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-dmlkZW8vYXBpL3NyYy9hcGkvYWNjZXNzX3Rva2VuL2RlbGV0ZS5ycw==) | `90.00% <100.00%> (-1.09%)` | :arrow_down: | | [video/api/src/api/events/ack.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-dmlkZW8vYXBpL3NyYy9hcGkvZXZlbnRzL2Fjay5ycw==) | `58.69% <100.00%> (ø)` | | | [video/api/src/api/events/fetch.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-dmlkZW8vYXBpL3NyYy9hcGkvZXZlbnRzL2ZldGNoLnJz) | `76.08% <100.00%> (ø)` | | | [video/api/src/api/playback\_key\_pair/create.rs](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV#diff-dmlkZW8vYXBpL3NyYy9hcGkvcGxheWJhY2tfa2V5X3BhaXIvY3JlYXRlLnJz) | `91.66% <100.00%> (ø)` | | | ... and [129 more](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/ScuffleTV/scuffle/pull/192/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScuffleTV)