Closed mmattbtw closed 1 year ago
Looks good so far, as discussed in discord switching to raw SCSS rather than tailwind is my only requirement!
if anyone @ScuffleTV/frontend wanna take a hit at these blured circles? for some reason i can't get it working with my scuffed normal css skills
you can just submit a PR to my branch on my fork and i'll fix up commits later https://github.com/mmattbtw/scuffle/tree/mmatt/start-frontend
I will try to do those circles
@mmattbtw Is the Figma design private? Now way to make it public read, private write?
@IS2511
@mmattbtw Is the Figma design private? Now way to make it public read, private write?
should be linked in #23 and the description of my PR, if you cant access it let @treuks know https://www.figma.com/file/o4N2UcWdZ77A8qbDvgJSoX/scuffle-design?node-id=0:1&t=fa9G8sxiNk26TaC7-0
alright, last thing todo before merge is to try to make it a little more responsive for mobile devices, gonna open it for review for final wording and such :-)
Merging #47 (c9e1a51) into main (5ce8251) will decrease coverage by
79.61%
. The diff coverage isn/a
.:exclamation: Current head c9e1a51 differs from pull request most recent head ac6f001. Consider uploading reports for the commit ac6f001 to get more accurate results
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 82.42% 2.81% -79.61%
==========================================
Files 29 30 +1
Lines 438 213 -225
==========================================
- Hits 361 6 -355
- Misses 77 207 +130
Impacted Files | Coverage Δ | |
---|---|---|
common/src/config.rs | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
common/src/logging.rs | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
backend/api/src/config.rs | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
backend/api/src/api/mod.rs | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
backend/api/src/api/v1/mod.rs | ||
backend/api/src/api/v1/users/mod.rs | ||
backend/api/src/api/v1/health.rs | ||
common/src/context.rs | ||
common/src/signal.rs | ||
frontend/player/src/utils.rs | 0.00% <0.00%> (ø) |
|
... and 5 more |
Inherited by #62
Proposed changes
Start the landing page using design from the Figma design
Closes #35
Types of changes
What types of changes does your code introduce to Scuffle? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.