ScuffleTV / scuffle

Live streaming platform
https://scuffle.tv
224 stars 25 forks source link

Website Design #62

Closed TroyKomodo closed 1 year ago

TroyKomodo commented 1 year ago

Proposed changes

Start the landing page using design from the Figma design

Closes #35

Types of changes

What types of changes does your code introduce to Scuffle? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further notes

Child of #47

codecov[bot] commented 1 year ago

Codecov Report

Merging #62 (cb1944e) into main (b94956a) will decrease coverage by 0.08%. The diff coverage is 86.96%.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   82.42%   82.34%   -0.08%     
==========================================
  Files          29       41      +12     
  Lines         438     1393     +955     
==========================================
+ Hits          361     1147     +786     
- Misses         77      246     +169     
Impacted Files Coverage Δ
common/src/config.rs 100.00% <ø> (ø)
common/src/lib.rs 100.00% <ø> (ø)
common/src/signal.rs 93.10% <ø> (ø)
common/src/types/channel.rs 0.00% <0.00%> (ø)
common/src/types/channel_ban.rs 0.00% <0.00%> (ø)
common/src/types/channel_role.rs 0.00% <0.00%> (ø)
common/src/types/channel_role_grant.rs 0.00% <0.00%> (ø)
common/src/types/chat_message.rs 0.00% <0.00%> (ø)
common/src/types/chat_room.rs 0.00% <0.00%> (ø)
common/src/types/follow.rs 0.00% <0.00%> (ø)
... and 28 more
IS2511 commented 1 year ago

This was never marked as ready for review so it never needed one... This doesn't seem like desirable behavior. @TroyKomodo every PR should probably be marked as ready for review before merging. image