ScuffleTV / scuffle

Live streaming platform
https://scuffle.tv
224 stars 25 forks source link

Feature/logo #65

Closed sirinoks closed 1 year ago

sirinoks commented 1 year ago

Proposed changes

Added logo to the repo. Also made prettier ignore .svg files

Solves #30

Types of changes

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

I might struggle with the process of the PR, so I will appreciate help. Also, feel free to tell me where to better put this.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/website@886fb47). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 3ed6530 differs from pull request most recent head d20dfe2. Consider uploading reports for the commit d20dfe2 to get more accurate results

@@                Coverage Diff                 @@
##             feature/website      #65   +/-   ##
==================================================
  Coverage                   ?   82.42%           
==================================================
  Files                      ?       29           
  Lines                      ?      438           
  Branches                   ?        0           
==================================================
  Hits                       ?      361           
  Misses                     ?       77           
  Partials                   ?        0           
IS2511 commented 1 year ago

@TroyKomodo PR closed without stating reason. The changes made it to the repo? How? Why is the PR closed then?


Solves #30

@sirinoks "solves" is not a reserved keyword on GH, but "closes" is. (Not sure if there are others, probably are.) Using that keyword makes it so a successful merge automatically closes the issue. Screenshot of a PR with "Closes #35" in the description

Screenshot of "Closes #35" after hovering on "Closes"

IS2511 commented 1 year ago

This PR was closed accidentally, continued in