Closed IS2511 closed 1 year ago
Still thinking about extend_route()
and that random ws.await
...
Would really like to fix styling of the gql methods args with their description macros, but haven't gotten to that yet. Kinda long to setup the repo, damn.
Merging #70 (e179427) into main (daf6e9c) will decrease coverage by
0.16%
. The diff coverage is100.00%
.:exclamation: Current head e179427 differs from pull request most recent head fb5b09c. Consider uploading reports for the commit fb5b09c to get more accurate results
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 82.94% 82.78% -0.16%
==========================================
Files 44 41 -3
Lines 1442 1388 -54
==========================================
- Hits 1196 1149 -47
+ Misses 246 239 -7
Impacted Files | Coverage Δ | |
---|---|---|
backend/api/src/api/error.rs | 98.79% <100.00%> (ø) |
|
backend/api/src/api/v1/gql/auth.rs | 89.57% <100.00%> (+0.12%) |
:arrow_up: |
backend/api/src/api/v1/gql/error.rs | 62.80% <100.00%> (ø) |
|
backend/api/src/api/v1/gql/handlers.rs | 84.88% <100.00%> (ø) |
|
backend/api/src/api/v1/gql/mod.rs | 94.73% <100.00%> (-0.14%) |
:arrow_down: |
backend/api/src/api/v1/middleware/auth.rs | 100.00% <100.00%> (+9.75%) |
:arrow_up: |
backend/api/src/config.rs | 100.00% <100.00%> (ø) |
|
backend/api/src/global/turnstile.rs | 100.00% <100.00%> (+15.00%) |
:arrow_up: |
common/src/types/session.rs | 100.00% <100.00%> (ø) |
|
... and 5 more |
If you are going to rename the extend_gql
method you might as well also rename the extend_route
method too.
Proposed changes
Implementing some of the minor changes discussed in my review of PR #63
Types of changes
What types of changes does your code introduce to Scuffle? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Time to sign that CLA :Clueless: