ScuffleTV / scuffle

Live streaming platform
https://scuffle.tv
224 stars 25 forks source link

fix: graphiql resource integrity #72

Closed 4w3Official closed 1 year ago

4w3Official commented 1 year ago

Proposed changes

fix resource integrity for graphiql.min.js from https://unpkg.com

Types of changes

What types of changes does your code introduce to Scuffle? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

OWASP Top 10 2021 Category A8 - Software and Data Integrity Failures MITRE, CWE-353 - Missing Support for Integrity Check OWASP Top 10 2017 Category A6 - Security Misconfiguration developer.mozilla.org - Subresource Integrity

codecov[bot] commented 1 year ago

Codecov Report

Merging #72 (daf6e9c) into main (9529c13) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files          44       44           
  Lines        1442     1442           
=======================================
  Hits         1196     1196           
  Misses        246      246           
TroyKomodo commented 1 year ago

Please rebase from main. Also please provide a commit description as to why this is better than just having it how it was.