Closed lennartkloock closed 1 year ago
i still have to add UTs
Merging #90 (329168e) into main (82cacaa) will increase coverage by
0.01%
. The diff coverage is76.49%
.:exclamation: Current head 329168e differs from pull request most recent head 5b6d1bf. Consider uploading reports for the commit 5b6d1bf to get more accurate results
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 73.94% 73.96% +0.01%
==========================================
Files 209 212 +3
Lines 15228 15447 +219
==========================================
+ Hits 11260 11425 +165
- Misses 3968 4022 +54
Impacted Files | Coverage Δ | |
---|---|---|
backend/api/src/api/v1/gql/error.rs | 62.69% <57.14%> (+0.40%) |
:arrow_up: |
backend/api/src/global/mod.rs | 69.67% <64.42%> (-30.33%) |
:arrow_down: |
backend/api/src/config.rs | 91.66% <68.42%> (-6.80%) |
:arrow_down: |
backend/api/src/api/v1/gql/subscription/user.rs | 90.00% <90.00%> (ø) |
|
backend/api/src/subscription.rs | 90.19% <90.19%> (ø) |
|
backend/api/src/api/v1/gql/mod.rs | 100.00% <100.00%> (ø) |
|
backend/api/src/api/v1/gql/models/user.rs | 75.22% <100.00%> (ø) |
|
backend/api/src/api/v1/gql/subscription/mod.rs | 100.00% <100.00%> (ø) |
This addresses the second point in #87
Proposed changes
This adds support for GQL pubsub event subscriptions for various events.
Types of changes
What types of changes does your code introduce to Scuffle? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.