This change refactors how we store the stream variants and also sets up the transcoder for unit tests and cleans up the way transcoder invokes ffmpeg.
Previously we did some jank way of having variants and then variants that reference other variants which was really messy.
Now we have variants and transcode states. Variants can either reference 1 or more transcode states.
The HLS manifest is then created to comprise these changes
In this manifest we transcode both AAC audio and OPUS audio, Opus is smaller and better quality than AAC so it should be preferred if the client supports Opus.
Types of changes
What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply
[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Proposed changes
Completes #86 bullet point 4
This change refactors how we store the stream variants and also sets up the transcoder for unit tests and cleans up the way transcoder invokes ffmpeg.
Previously we did some jank way of having variants and then variants that reference other variants which was really messy. Now we have variants and transcode states. Variants can either reference 1 or more transcode states. The HLS manifest is then created to comprise these changes
In this manifest we transcode both
AAC
audio andOPUS
audio, Opus is smaller and better quality than AAC so it should be preferred if the client supports Opus.Types of changes
What types of changes does your code introduce to Scuffle? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.