ScuffleTV / scuffle

Live streaming platform
https://scuffle.tv
224 stars 25 forks source link

fix: proto compiler call in api build script #92

Closed lennartkloock closed 1 year ago

lennartkloock commented 1 year ago

Proposed changes

The proto compiler needs the special flag --experimental_allow_proto3_optional to compile our .proto files. The same code is used in the edge, ingest and transcoder build scripts.

Types of changes

What types of changes does your code introduce to Scuffle? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

TroyKomodo commented 1 year ago

Can you do it for all of them?

lennartkloock commented 1 year ago

Can you do it for all of them?

What do you mean? It's already done for edge, ingest and transcoder. I just copied the code.

TroyKomodo commented 1 year ago

Oh I didnt realize it was already done.