codecov[bot]
commented
1 year ago Codecov Report
Merging #95 (82cacaa) into main (192e363) will increase coverage by
0.05%. The diff coverage is92.59%.
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 73.88% 73.94% +0.05%
==========================================
Files 209 209
Lines 15196 15228 +32
==========================================
+ Hits 11228 11260 +32
Misses 3968 3968 | Impacted Files | Coverage Δ | |
|---|---|---|
| backend/api/src/database/stream.rs | 47.61% <35.71%> (ø) |
|
| backend/api/src/grpc/api.rs | 80.96% <94.44%> (ø) |
|
| video/ingest/src/ingest/connection.rs | 68.20% <100.00%> (+0.37%) |
:arrow_up: |
| video/ingest/src/ingest/variants.rs | 99.41% <100.00%> (+0.07%) |
:arrow_up: |
| video/transcoder/src/transcoder/job/mod.rs | 76.12% <100.00%> (+0.59%) |
:arrow_up: |
Proposed changes
This is not part of the HLS spec but it provides extra information for our player so we can prioritize OPUS > AAC when we have both available. (if the player supports opus decode)
Notice the last 2 lines, this allows our player to pick the appropriate version based on a priority specified here.
Types of changes
What types of changes does your code introduce to Scuffle? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.