Closed lennartkloock closed 1 year ago
Merging #97 (2a04f77) into main (1dd88a4) will decrease coverage by
0.29%
. The diff coverage is72.33%
.:exclamation: Current head 2a04f77 differs from pull request most recent head 9b7bcda. Consider uploading reports for the commit 9b7bcda to get more accurate results
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 74.20% 73.91% -0.29%
==========================================
Files 216 229 +13
Lines 15628 17440 +1812
==========================================
+ Hits 11596 12890 +1294
- Misses 4032 4550 +518
Impacted Files | Coverage Δ | |
---|---|---|
backend/api/src/api/v1/gql/handlers.rs | 74.87% <0.00%> (-4.29%) |
:arrow_down: |
config/config/src/error.rs | 26.96% <26.96%> (ø) |
|
backend/api/src/api/middleware/auth.rs | 89.83% <50.00%> (ø) |
|
config/config/src/sources/utils.rs | 50.76% <50.76%> (ø) |
|
config/config/src/primitives.rs | 56.20% <56.20%> (ø) |
|
video/transcoder/src/transcoder/job/variant/mod.rs | 78.34% <60.71%> (-0.74%) |
:arrow_down: |
backend/api/src/api/v1/gql/subscription/user.rs | 90.69% <62.50%> (-3.90%) |
:arrow_down: |
common/src/logging.rs | 87.50% <62.50%> (-7.50%) |
:arrow_down: |
backend/api/src/grpc/api.rs | 80.87% <66.66%> (-0.10%) |
:arrow_down: |
config/config/src/sources/file/json.rs | 69.56% <69.56%> (ø) |
|
... and 20 more |
Proposed changes
Added a new configuration system which allows for:
Supports a hierarchy system so you can specify which values to use over other values.
Types of changes
What types of changes does your code introduce to Scuffle? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.