Sculas
commented
10 months ago Hi! Yes, this is a known issue. I'm almost done with my PR at BCP (https://github.com/notnips/Brutal-Company-Plus/pull/1) which will add an event API that I can use in BCA, which also fixes this issue.
That was the reason I didn't implement event weights in BCA, because I thought I'd get this PR finished quickly anyway... but then the holidays came 😅
Brutal Company Plus allows you to assign a chance of an event happening in the config, while this mod doesn't. I have my Brutal Company event values lowered (besides "Nothing Happened Today") because I like there to not be an event everyday, but it seems like this mod overrides the original event selection logic. This is resulting in events happening every day regardless of the config values in the original mod. IMO even if you don't change this, I feel like you should at least mention that it changes the event selection logic in the mod description.
Original BCP logic:
https://github.com/notnips/Brutal-Company-Plus/blob/8112367dbe6b960d3bc9fcd05ce209497d0d5a32/Plugins.cs#L334C19-L334C19
https://github.com/notnips/Brutal-Company-Plus/blob/8112367dbe6b960d3bc9fcd05ce209497d0d5a32/Plugins.cs#L458
Modified BCA logic:
https://github.com/Sculas/BrutalCompanyAdditions/blob/c1b7dee2e33096ef900d68ac07e2472da993f4bc/Utils.cs#L50C3-L50C3