search

SeaCloudsEU / SeaCloudsPlatform

Seamless adaptive multi-cloud management of service-based applications
http://www.seaclouds-project.eu/
Apache License 2.0
18 stars 20 forks source link

Changes the relationships format to a map inside endpoint element. #272

Closed rosogon closed 8 years ago

rosogon commented 8 years ago

A relationship is now like:

requirements:
- endpoint:
    node: targetNode
    type: relationType
    properties:
      prop.name: connurl

when previously was defined like:

requirements:
- endpoint: targetNode
  type: relationType
  properties:
    prop.name: connurl

This change facilitates the generic handling of relationships in the DAM generation.

rosogon commented 8 years ago

@kiuby88, @perezp : Could you have a look?

codecov-io commented 8 years ago

Current coverage is 38.63%

Merging #272 into master will increase coverage by +1.90% as of 23139e4

@@            master    #272   diff @@
======================================
  Files          329     332     +3
  Stmts        12064   12560   +496
  Branches      1548    1596    +48
  Methods          0       0       
======================================
+ Hit           4432    4853   +421
+ Partial        449     420    -29
- Missed        7183    7287   +104

Review entire Coverage Diff as of 23139e4

Powered by Codecov. Updated on successful CI builds.

kiuby88 commented 8 years ago

Good work @rosogon, it looks good to me. I have just added a pair of minor comments

rosogon commented 8 years ago

Ok. Comments addressed. I'll squash and merge.