search

SeaDve / Breathing

Relax and meditate
GNU General Public License v3.0
59 stars 10 forks source link

Refactoring #16

Open jokuNimi opened 1 year ago

jokuNimi commented 1 year ago

Hi. I'm considering implementing the feature request #4. In issue #14 SeaDve says

I would like to mention though that Breathing's animation and timer code is very hacky and not very extensible. I did have plans on major refactoring, but haven't got that time yet.

What sort of refactoring did you (SeaDve) have in mind, and do you think that should be done before implementing new features? It looks like some refactoring is needed in any case, and I could do something a bit fancier if I end up doing some refactoring anyway.

PS. Feel free to close this issue, since it's not really an issue. This was just the easiest way for me to ask a question.

SeaDve commented 1 year ago

Thanks for looking forward to contribute!

One of the first step as far as I remember is to do the animation using AdwAnimation and GtkSnapshot APIs. This would give a lot more control compared to using css classes.