search

SeaDve / Kooha

Elegantly record your screen
GNU General Public License v3.0
2.63k stars 70 forks source link

Kooha monitor rotated #250

Closed ianhattendorf closed 8 months ago

ianhattendorf commented 1 year ago

Affected version

Sway 1.8.1

Bug summary

A rotated monitor is recorded as rotated. It would be nice to have some sort of control over this, as typically monitors are rotated so that they are still viewed normally. A monitor moved into portrait mode would be rotated in software 90 or 270 degrees, but I would expect to be able to record right side up.

In this case, to fix the recording I need to re-encode the video via ffmpeg -i <video> -vf 'transpose=1' <out>. This isn't ideal as it's slow, kills battery, and loses quality.

Steps to reproduce

  1. Open Kooha
  2. Record on rotated monitor
  3. Recording is rotated

Expected behavior

Recording is not rotated

Relevant logs, screenshots, screencasts, etc.

image

ianhattendorf commented 1 year ago

If this is an upstream issue (flatpak, xdg-desktop-portal-wlr, wlroots,etc.) please redirect me. Thanks!

SeaDve commented 8 months ago

I think this may be a bug in your compositor.

It seems to be fine in GNOME atleast: image

SeaDve commented 8 months ago

Thanks for reporting btw. However, I'll close this for now since I don't think we can do much from Kooha's side. Feel free to reopen though if otherwise it is.

SeaDve commented 8 months ago

Hello, I have pushed a fix in the main branch. If you have the time, please test it. Thank youu!

ianhattendorf commented 4 months ago

Hello, I have pushed a fix in the main branch. If you have the time, please test it. Thank youu!

Sorry, missed that this was resolved. I don't have a rotated monitor anymore, but a quick test confirms that it's fixed. Thanks!