SeaDve / Kooha

Elegantly record your screen
GNU General Public License v3.0
2.63k stars 70 forks source link

Recording stopwatch's seconds counter increments more than once per second #280

Closed nekohayo closed 9 months ago

nekohayo commented 9 months ago

Affected version

git main, and the stable version too, IIRC.

Bug summary

The seconds counter refreshes at a seemingly variable rate. See video below.

Steps to reproduce

In my case, it happens simply by recording a portion of the screen with microphone active. I haven't tried other combinations.

This may or may not be influenced by system load or idleness, such as whether or not you move the mouse cursor, I am not sure.

Tested on the Wayland version of GNOME 45.3 on Fedora 39.

Relevant logs, screenshots, screencasts, etc.

Kooha stopwatch seconds wonkiness.webm

SeaDve commented 9 months ago

The time is provided by querying the position on the pipeline. I think this may be caused by the encoder being slow. Can you reproduce it with mp4, which has a much faster encoder?

SeaDve commented 9 months ago

We could provide our own timer, like pre-2.0 versions, it would increment more consistently, but it wouldn't be as accurate, especially if the encoder is slow.

nekohayo commented 9 months ago

Oh yes indeed, it seems the issue does not happen with the MP4 encoder.

By the way, it might also be worth being more specific in the UI about which video codecs are used (H.264 vs VP8 vs VP9 vs AV1…) with some sort of indication of which one(s) tend to give the best performance vs compatibility etc.? Because container formats like MP4, WebM and Matroska are not really that useful to make a decision...

SeaDve commented 9 months ago

Thanks for the confirmation.

By the way, it might also be worth being more specific in the UI about which video codecs are used (H.264 vs VP8 vs VP9 vs AV1…) with some sort of indication of which one(s) tend to give the best performance vs compatibility etc.? Because container formats like MP4, WebM and Matroska are not really that useful to make a decision...

Feel free to open another issue about that one. I would close this as non-actionable/won't fix.