search

SeaDve / Kooha

Elegantly record your screen
GNU General Public License v3.0
2.61k stars 69 forks source link

Cleanly shutdown / finish encoding when interrupting the recording externally via GNOME Shell's video recording indicator button #287

Open nekohayo opened 7 months ago

nekohayo commented 7 months ago

Affected version

Bug summary

When interrupting recording via GNOME Shell, Kooha should still be able to finish encoding a valid file.

Steps to reproduce

  1. Start recording with Kooha
  2. Click GNOME Shell's orange video recording indicator button in the system menu (top-right corner), as it is faster / more convenient than fishing out Kooha's window from within the pile of windows.

Current result: Kooha outputs a broken video file in this situation.

Expected result: if possible, I would still expect Kooha to finalize the recording into a playable video file (after all, this works fine with GNOME Shell's built-in video recorder), instead of a corrupt file.

SeaDve commented 7 months ago

I have attempted to fix this before, but haven't spent enough time. :D It's harder than I thought; a fix in pipewire may be needed upstream.

Fisherworks commented 2 months ago

experiencing this on Arch linux x86_64, installed with pacman, kooha version 2.3.0-6, with kernel 6.10.7-arch1-1 #1 SMP PREEMPT_DYNAMIC Works OK with the recording stopped by the Kooha UI, but NOT OK with GNOME (version 46.4) panel button.