search

SeaDve / Kooha

Elegantly record your screen
GNU General Public License v3.0
2.54k stars 69 forks source link

Validating appstream file fails #6

Closed yochananmarqos closed 3 years ago

yochananmarqos commented 3 years ago 
Log of Meson test suite run on 2021-03-14T00:28:30.669786

Inherited environment: SHELL=/bin/bash COLORTERM=truecolor SUDO_GID=0 TEXTDOMAINDIR=/usr/share/locale SUDO_COMMAND='/bin/bash -c chrootbuild kooha fs' SUDO_USER=root PWD=/build/kooha/src SOURCE_DATE_EPOCH=1615681708 LOGNAME=builduser CXXFLAGS='-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' XAUTHORITY=/run/user/1000/gdm/Xauthority COMMAND_MODE=legacy LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now HOME=/build LANG=en_US.utf8 CPPFLAGS=-D_FORTIFY_SOURCE=2 MAKEFLAGS=-j17 TERM=xterm-256color USER=builduser DISPLAY=:1 SHLVL=2 LC_ALL=en_US.UTF-8 CHOST=x86_64-pc-linux-gnu PATH=/build/.local/bin:/build/.local/bin:/build/.local/bin:/home/yochanan/bin:/home/yochanan/.local/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl CFLAGS='-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' SUDO_UID=0 MAIL=/var/mail/builduser OLDPWD=/build/kooha/src TEXTDOMAIN=pacman-scripts _=/usr/bin/meson 

1/3 Validate desktop file   OK              0.00s
00:28:30 MALLOC_PERTURB_=119 /usr/bin/desktop-file-validate data/io.github.seadve.Kooha.desktop
----------------------------------- output -----------------------------------
------------------------------------------------------------------------------

2/3 Validate schema file    OK              0.00s
00:28:30 MALLOC_PERTURB_=163 /usr/bin/glib-compile-schemas --strict --dry-run /build/kooha/src/Kooha/data
----------------------------------- output -----------------------------------
------------------------------------------------------------------------------

3/3 Validate appstream file FAIL            1.51s   exit status 1
00:28:30 MALLOC_PERTURB_=111 /usr/bin/appstream-util validate data/io.github.seadve.Kooha.appdata.xml
----------------------------------- output -----------------------------------
stdout:
data/io.github.seadve.Kooha.appdata.xml: FAILED:
• attribute-invalid     : <screenshot> width (265) too small [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot.png] minimum is 624px
• attribute-invalid     : <screenshot> height too small [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot.png] minimum is 351px
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot.png]
• attribute-invalid     : <screenshot> width (265) too small [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot2.png] minimum is 624px
• attribute-invalid     : <screenshot> height too small [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot2.png] minimum is 351px
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot2.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot2.png]
• attribute-invalid     : <screenshot> width (265) too small [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot3.png] minimum is 624px
• attribute-invalid     : <screenshot> height too small [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot3.png] minimum is 351px
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot3.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/SeaDve/Kooha/master/screenshots/Kooha-screenshot3.png]
stderr:
Validation of files failed
------------------------------------------------------------------------------

Summary of Failures:

3/3 Validate appstream file FAIL            1.51s   exit status 1

Ok:                 2   
Expected Fail:      0   
Fail:               1   
Unexpected Pass:    0   
Skipped:            0   
Timeout:            0
SeaDve commented 3 years ago

What building command did you use? I cannot reproduce it, but I assume it has something to do with screenshots having too low resolution.

yochananmarqos commented 3 years ago

arch-meson Kooha build meson compile -C build meson test -C build

SeaDve commented 3 years ago

meson builddir --prefix=/usr/local sudo ninja -C builddir install Try these.

yochananmarqos commented 3 years ago

It builds fine, that's not the issue. The desktop and schema tests pass as you can see above.

I assume it has something to do with screenshots having too low resolution.

Indeed.

SeaDve commented 3 years ago

And also maybe has something to do with screenshots having transparent borders. Replacing it with a nontransparent one might mess up the readme and make it redundant if I upload a nontransparent one. I think I'll just upload higher resolution screenshots and maybe close the issue?

yochananmarqos commented 3 years ago

also maybe has something to do with screenshots having transparent borders

Yeah, that too. That must be the padding it's complaining about.

SeaDve commented 3 years ago

For now, I won't fix these issues since they are pretty trivial, it's up to you if you wanna close it. But, before 2.0.0 release I'll try to

yochananmarqos commented 3 years ago

No worries. It's not really a big deal.

SeaDve commented 3 years ago

I found out that this is linked with a bigger issue. For some reason, flathub buildbot didn't detect the issue, and I'm not sure if it is just me, the screenshots aren't showing in the flathub website. I'll fix it asap.

yochananmarqos commented 3 years ago

The images are definitively not loading on Flathub.

SeaDve commented 3 years ago

arch-meson Kooha build meson compile -C build meson test -C build

This should now work on the latest commit. Not sure with flatpak screenshot one

SeaDve commented 3 years ago

I checked the flathub page, it seems to be fixed. Closing this now, thanks!

yochananmarqos commented 3 years ago

Yes, it's working now. I added it to the AUR, by the way: kooha

SeaDve commented 3 years ago

Yes, it's working now. I added it to the AUR, by the way: kooha

Thanks! I'll add it to Readme tomorrow.

bronvic commented 3 years ago

I just faced the same error during instalation from aur

Log of Meson test suite run on 2021-08-02T19:20:07.244267

Inherited environment: SHELL=/usr/bin/zsh LSCOLORS=Gxfxcxdxbxegedabagacad COLORTERM=truecolor LESS=-R I3SOCK=/run/user/1000/sway-ipc.1000.516.sock TEXTDOMAINDIR=/usr/share/locale XCURSOR_SIZE=24 EDITOR=vim XDG_SEAT=seat0 PWD=/home/voronwe/.cache/paru/clone/kooha/src SOURCE_DATE_EPOCH=1627921205 XDG_SESSION_DESKTOP=sway LOGNAME=voronwe XDG_SESSION_TYPE=wayland CXXFLAGS='-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS' MOTD_SHOWN=pam COMMAND_MODE=legacy LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now HOME=/home/voronwe LANG=en_US.UTF-8 HISTFILE=/home/voronwe/.config/postgresql/.psql_history LS_COLORS='' XDG_CURRENT_DESKTOP=sway PULSE_COOKIE=/home/voronwe/.config/pulse/cookie SWAYSOCK=/run/user/1000/sway-ipc.1000.516.sock WAYLAND_DISPLAY=wayland-1 SSL_CERT_DIR=/etc/ssl/certs XDG_SESSION_CLASS=user TERM=alacritty ZSH=/home/voronwe/.oh-my-zsh RUSTUP_HOME=/home/voronwe/.config/rust USER=voronwe SHLVL=3 MOZ_ENABLE_WAYLAND=1 PAGER=less XDG_VTNR=7 XDG_SESSION_ID=4 XDG_RUNTIME_DIR=/run/user/1000 SSL_CERT_FILE=/etc/ssl/cert.pem GREETD_SOCK=/run/greetd-488.sock CHOST=x86_64-pc-linux-gnu PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl ALACRITTY_LOG=/tmp/Alacritty-90966.log CFLAGS='-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection' DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus MAIL=/var/spool/mail/voronwe OLDPWD=/home/voronwe/.cache/paru/clone/kooha/src TEXTDOMAIN=pacman-scripts _=/usr/bin/meson

1/3 Validate desktop file   OK              0.01s
16:20:07 MALLOC_PERTURB_=181 /usr/bin/desktop-file-validate data/io.github.seadve.Kooha.desktop
----------------------------------- output -----------------------------------
------------------------------------------------------------------------------

2/3 Validate schema file    OK              0.00s
16:20:07 MALLOC_PERTURB_=155 /usr/bin/glib-compile-schemas --strict --dry-run /home/voronwe/.cache/paru/clone/kooha/src/Kooha-1.2.1/data
----------------------------------- output -----------------------------------
------------------------------------------------------------------------------

3/3 Validate appstream file FAIL            0.82s   exit status 1
16:20:07 MALLOC_PERTURB_=159 /usr/bin/appstream-util validate-relax data/io.github.seadve.Kooha.appdata.xml
----------------------------------- output -----------------------------------
stdout:
data/io.github.seadve.Kooha.appdata.xml: FAILED:
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://raw.githubusercontent.com/SeaDve/Kooha/main/screenshots/Kooha-screenshot.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://raw.githubusercontent.com/SeaDve/Kooha/main/screenshots/Kooha-screenshot2.png]
• url-not-found         : <screenshot> failed to download (HTTP 404: Not Found) [https://raw.githubusercontent.com/SeaDve/Kooha/main/screenshots/Kooha-screenshot3.png]
stderr:
Validation of files failed
------------------------------------------------------------------------------

Summary of Failures:

3/3 Validate appstream file FAIL            0.82s   exit status 1

Ok:                 2
Expected Fail:      0
Fail:               1
Unexpected Pass:    0
Skipped:            0
Timeout:            0

Can you take a look?

yochananmarqos commented 3 years ago

@bronvic I've disabled the Validate appstream file test for now for the AUR package.