SeaDve / Mousai

Identify songs in seconds
GNU General Public License v3.0
1.01k stars 38 forks source link

Mousai crashes when selecting a song #85

Closed rene-coty closed 1 year ago

rene-coty commented 1 year ago

When I select a song from the main page using the select button, the app crashes and I have to relaunch it. Same bug occurs when I right-click on a song, or when I choose the 'Select all' option above. So it's related to selection specifically.. Here is a recording showing the issue: Capture vidéo du 2023-05-02 09-40-13.webm Here is the output on Console: Capture d’écran du 2023-05-02 09-34-18

SeaDve commented 1 year ago

could you provide extra information about your system, specifically the one asked in the issue template?

It would also be useful to add RUST_BACKTRACE=1 before the command to run Mousai

SeaDve commented 1 year ago

I think I might have figure it out. If you used different locale, other than en_US, the translation may have translated the string incorrectly. For example, Removed {} song maybe translated to لا تزل الأغنية, which doesn't have {}, causing gettextrs (the library used for Mousai translation) to panic

rene-coty commented 1 year ago

could you provide extra information about your system, specifically the one asked in the issue template?

Sorry I forgot to mention these:

Capture d’écran du 2023-05-02 10-30-16

SeaDve commented 1 year ago

Do you use a different locale, other than the default?

rene-coty commented 1 year ago

Yes, French (fr)

SeaDve commented 1 year ago

I'll do a release today. Hopefully, that should fix it

SeaDve commented 1 year ago

You could test the new version early using the following command:

flatpak install --user https://dl.flathub.org/build-repo/21338/io.github.seadve.Mousai.flatpakref

Edit: The release has been btw published, no need to run this