SeaGL / seagl-terraform

Terraform used to maintain SeaGL's VMs, RDS database, DNS, etc.
GNU Affero General Public License v3.0
1 stars 2 forks source link

Remove unneeded SES email identity #6

Closed strugee closed 7 months ago

github-actions[bot] commented 2 years ago

Terraform Format and Style 🖌``

Terraform Initialization ⚙️success

Terraform Plan 📖success

Terraform Validation 🤖success

Show Plan ``` terraform random_password.osem_db_master_pass: Refreshing state... [id=none] aws_route53_record.route_53_root_txt: Refreshing state... [id=Z0173878287JIU5M4KB8R__TXT] aws_ses_email_identity.email: Refreshing state... [id=sre@seagl.org] aws_db_subnet_group.osem: Refreshing state... [id=osem] aws_secretsmanager_secret.osem-db-pass: Refreshing state... [id=arn:aws:secretsmanager:us-west-2:663166083306:secret:db-pass-osem-5KW1mS] aws_instance.dokku: Refreshing state... [id=i-02ee81d4bd0860d30] aws_s3_bucket.state: Refreshing state... [id=seagl-terraform] data.aws_vpc.vpc: Reading... aws_route53_record.route_53_dmarc_txt: Refreshing state... [id=Z0173878287JIU5M4KB8R__dmarc.seagl.org_TXT] aws_ses_domain_identity.seagl: Refreshing state... [id=seagl.org] aws_ses_domain_identity.email_domain_identity: Refreshing state... [id=seagl.org] aws_route53_record.seagl_amazonses_verification_record: Refreshing state... [id=Z0173878287JIU5M4KB8R__amazonses.seagl.org_TXT] aws_ses_domain_dkim.email_dkim: Refreshing state... [id=seagl.org] aws_secretsmanager_secret_version.osem-db-pass-val: Refreshing state... [id=arn:aws:secretsmanager:us-west-2:663166083306:secret:db-pass-osem-5KW1mS|5E8ED816-E9AA-4E8E-A382-2EEE9FC74A66] aws_route53_record.email_dkim_records[2]: Refreshing state... [id=Z0173878287JIU5M4KB8R_o7o3tsrrlwgkmmx3a7f5njkrvi75woso._domainkey.seagl.org_CNAME] aws_route53_record.email_dkim_records[1]: Refreshing state... [id=Z0173878287JIU5M4KB8R_zjerfwsrr5wpwp5p5klnsrrzp6ralpcp._domainkey.seagl.org_CNAME] aws_route53_record.email_dkim_records[0]: Refreshing state... [id=Z0173878287JIU5M4KB8R_nldzqxeyq5fyslu3tzvj4ltbwbexupuj._domainkey.seagl.org_CNAME] data.aws_vpc.vpc: Read complete after 2s [id=vpc-231ecb46] aws_security_group.osem_rds_security_group: Refreshing state... [id=sg-006c493d98f3c7f1a] aws_security_group_rule.private_out: Refreshing state... [id=sgrule-1612436969] aws_security_group_rule.private_in: Refreshing state... [id=sgrule-3182957500] aws_db_instance.osem: Refreshing state... [id=osem] aws_s3_bucket_versioning.state: Refreshing state... [id=seagl-terraform] aws_s3_bucket_public_access_block.state: Refreshing state... [id=seagl-terraform] Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: + create - destroy Terraform will perform the following actions: # aws_s3_bucket_acl.state will be created + resource "aws_s3_bucket_acl" "state" { + acl = "private" + bucket = "seagl-terraform" + id = (known after apply) + access_control_policy { + grant { + permission = (known after apply) + grantee { + display_name = (known after apply) + email_address = (known after apply) + id = (known after apply) + type = (known after apply) + uri = (known after apply) } } + owner { + display_name = (known after apply) + id = (known after apply) } } } # aws_ses_email_identity.email will be destroyed # (because aws_ses_email_identity.email is not in configuration) - resource "aws_ses_email_identity" "email" { - arn = "arn:aws:ses:us-west-2:663166083306:identity/sre@seagl.org" -> null - email = "sre@seagl.org" -> null - id = "sre@seagl.org" -> null } Plan: 1 to add, 0 to change, 1 to destroy. ───────────────────────────────────────────────────────────────────────────── Note: You didn't use the -out option to save this plan, so Terraform can't guarantee to take exactly these actions if you run "terraform apply" now. ```

Pushed by: @strugee, Action: pull_request

sntxrr commented 2 years ago

@strugee not sure if you saw my feedback on this PR - I think there is another place to remove the email

strugee commented 2 years ago

@sntxrr I don't think this is a problem since 063f76e3fcfc5930078ade66c064dbfffc52bdfa landed?

github-actions[bot] commented 2 years ago

Terraform Format and Style 🖌``

Terraform Initialization ⚙️success

Terraform Plan 📖success

Terraform Validation 🤖success

Show Plan ``` terraform random_password.osem_db_master_pass: Refreshing state... [id=none] data.aws_vpc.vpc: Reading... aws_ses_email_identity.email: Refreshing state... [id=sre@seagl.org] aws_db_subnet_group.osem: Refreshing state... [id=osem] aws_ses_domain_identity.email_domain_identity: Refreshing state... [id=seagl.org] aws_route53_record.alias: Refreshing state... [id=Z0173878287JIU5M4KB8R_alias.seagl.org_CNAME] aws_route53_record.route_53_dmarc_txt: Refreshing state... [id=Z0173878287JIU5M4KB8R__dmarc.seagl.org_TXT] aws_ses_domain_identity.seagl: Refreshing state... [id=seagl.org] aws_route53_record.route_53_root_txt: Refreshing state... [id=Z0173878287JIU5M4KB8R__TXT] aws_secretsmanager_secret.osem-db-pass: Refreshing state... [id=arn:aws:secretsmanager:us-west-2:663166083306:secret:db-pass-osem-5KW1mS] aws_instance.dokku: Refreshing state... [id=i-02ee81d4bd0860d30] aws_s3_bucket.state: Refreshing state... [id=seagl-terraform] aws_ses_domain_dkim.email_dkim: Refreshing state... [id=seagl.org] aws_route53_record.seagl_amazonses_verification_record: Refreshing state... [id=Z0173878287JIU5M4KB8R__amazonses.seagl.org_TXT] aws_route53_record.email_dkim_records[2]: Refreshing state... [id=Z0173878287JIU5M4KB8R_o7o3tsrrlwgkmmx3a7f5njkrvi75woso._domainkey.seagl.org_CNAME] aws_route53_record.email_dkim_records[0]: Refreshing state... [id=Z0173878287JIU5M4KB8R_nldzqxeyq5fyslu3tzvj4ltbwbexupuj._domainkey.seagl.org_CNAME] aws_route53_record.email_dkim_records[1]: Refreshing state... [id=Z0173878287JIU5M4KB8R_zjerfwsrr5wpwp5p5klnsrrzp6ralpcp._domainkey.seagl.org_CNAME] aws_secretsmanager_secret_version.osem-db-pass-val: Refreshing state... [id=arn:aws:secretsmanager:us-west-2:663166083306:secret:db-pass-osem-5KW1mS|5E8ED816-E9AA-4E8E-A382-2EEE9FC74A66] data.aws_vpc.vpc: Read complete after 2s [id=vpc-231ecb46] aws_security_group.osem_rds_security_group: Refreshing state... [id=sg-006c493d98f3c7f1a] aws_security_group_rule.private_in: Refreshing state... [id=sgrule-3182957500] aws_security_group_rule.private_out: Refreshing state... [id=sgrule-1612436969] aws_db_instance.osem: Refreshing state... [id=osem] aws_s3_bucket_versioning.state: Refreshing state... [id=seagl-terraform] aws_s3_bucket_public_access_block.state: Refreshing state... [id=seagl-terraform] Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: + create - destroy Terraform will perform the following actions: # aws_s3_bucket_acl.state will be created + resource "aws_s3_bucket_acl" "state" { + acl = "private" + bucket = "seagl-terraform" + id = (known after apply) + access_control_policy { + grant { + permission = (known after apply) + grantee { + display_name = (known after apply) + email_address = (known after apply) + id = (known after apply) + type = (known after apply) + uri = (known after apply) } } + owner { + display_name = (known after apply) + id = (known after apply) } } } # aws_ses_email_identity.email will be destroyed # (because aws_ses_email_identity.email is not in configuration) - resource "aws_ses_email_identity" "email" { - arn = "arn:aws:ses:us-west-2:663166083306:identity/sre@seagl.org" -> null - email = "sre@seagl.org" -> null - id = "sre@seagl.org" -> null } Plan: 1 to add, 0 to change, 1 to destroy. ───────────────────────────────────────────────────────────────────────────── Note: You didn't use the -out option to save this plan, so Terraform can't guarantee to take exactly these actions if you run "terraform apply" now. ```

Pushed by: @strugee, Action: pull_request

strugee commented 7 months ago

Closing since this has bitrotted and will be even more bitrotted after #49 - which includes a TODO comment about removing this anyway - lands.