search

SeaQL / otter-sql

🦦 An Embeddable SQL Executor in Rust
Apache License 2.0
26 stars 2 forks source link

Codegen Part 1 #14

Closed Samyak2 closed 2 years ago

Samyak2 commented 2 years ago

PR Info

Adds

Fixes

Breaking Changes

Changes

tyt2y3 commented 2 years ago

I think everything starts to make sense now and I can imagine the end result. Hopefully I will be able to see it soon!

tyt2y3 commented 2 years ago

Is there a basic implementation of the expression evaluator? I would like to see some test case for it.

Samyak2 commented 2 years ago

Is there a basic implementation of the expression evaluator? I would like to see some test case for it.

Not yet. This PR is just for the codegen

Samyak2 commented 2 years ago

The next thing to implement is codegen for select statements. Once that is done, we can merge this PR and I can start working on the executor for Expr.

tyt2y3 commented 2 years ago

Looks good so far. Can't wait to see and play with test cases that actually executes them!

Samyak2 commented 2 years ago

A few more tests for SELECT are remaining.

Samyak2 commented 2 years ago

Done. The reasoning for commenting out some of the IC tests is given here: 85efe9037ded65eb77cef2ecff9e9a16a8668b2e

Samyak2 commented 2 years ago

All done in this PR now @tyt2y3