search

SeaQL / sea-orm

🐚 An async & dynamic ORM for Rust
https://www.sea-ql.org/SeaORM/
Apache License 2.0
6.57k stars 461 forks source link

doc: code blocks looks weird in light mode #2116

Closed ssiyad closed 4 months ago

ssiyad commented 4 months ago

Code blocks in docs looks weird/unreadable in light mode. Looks okay in dark. Example - https://www.sea-ql.org/SeaORM/docs/relation/one-to-one/#defining-the-relation

tyt2y3 commented 4 months ago

oh it really is. I don't know how to fix it though

ssiyad commented 4 months ago

Also, even in dark mode, the contrast is too low on highlighted lines.

image
tyt2y3 commented 4 months ago

Ah right, may be we should override the highlight color in CSS.

billy1624 commented 4 months ago

Hey @ssiyad, thanks for the prompt! I just fixed the theme, https://github.com/SeaQL/seaql.github.io/commit/93501d5ce09de2c62ea07517cb7065b94cc59d6a. Please check again!

billy1624 commented 4 months ago

Fixed on https://github.com/SeaQL/seaql.github.io/commit/93501d5ce09de2c62ea07517cb7065b94cc59d6a

ssiyad commented 4 months ago

@billy1624 It looks so much better now. Thanks!

tyt2y3 commented 4 months ago

Many thanks!