search

SeaQL / sea-orm

🐚 An async & dynamic ORM for Rust
https://www.sea-ql.org/SeaORM/
Apache License 2.0
6.57k stars 461 forks source link

Missing okapi support #2135

Closed m4tx closed 3 months ago

m4tx commented 4 months ago

Description

Raising this as a bug, both because there is a broken example on the repo, and because the breakage in question hasn't been communicated as a major version bump/info in changelog.

I can see that the support to rocket_okapi has been added in #1071, and then removed in c3b725662291b17142a7b5ab4b8ab022f1d0d78e. This has been included as part of 0.12.5 release (0.12.4...0.12.5), but its changelog doesn't mention this (breaking) change.

It would be nice to get the rocket_okapi support back or get a reason for removing the support and in this case, removal of the example and feature flag from the repository. Now it's misleading, as the example suggests that the support is there, while it doesn't work.

Steps to Reproduce

  1. Clone the sea-orm repo
  2. cd examples/rocket_okapi_example
  3. cargo run

Expected Behavior

The example compiles and runs.

Actual Behavior

It fails with failed to resolve: use of undeclared crate or module rocket_okapi (among other errors).

Reproduces How Often

Always

Workarounds

I looked at the git history and found out the support has been silently removed in c3b725662291b17142a7b5ab4b8ab022f1d0d78e.

Versions

m4tx commented 4 months ago

Ah, now I see it's been removed because when #1959 was created, okapi hasn't been updated to work with the latest Rocket version yet... I can spin up a PR that'll fix this