SeaQL / sea-orm

🐚 An async & dynamic ORM for Rust
https://www.sea-ql.org/SeaORM/
Apache License 2.0
6.56k stars 459 forks source link

Exposing connection pools for sqlite #2233

Closed ys928 closed 1 month ago

ys928 commented 1 month ago

PR Info

Changes

tyt2y3 commented 1 month ago

I think this might be what you're looking for? https://github.com/SeaQL/sea-orm/blob/010433bf1633dd387f8493071c0b3838a7fbb575/src/database/db_connection.rs#L537

ys928 commented 1 month ago

thanks, I didn't find it beforehand, turns out I also needed to add a sea-orm-internal feature to show this function in vscode's autocompletion

tyt2y3 commented 1 month ago

I think I will expose it by default moving forward

ys928 commented 1 month ago

That's great, but I think this function should be included in the sqlx-sqlite feature.After all, it might not make sense to be able to use it without enabling this feature.

tyt2y3 commented 1 month ago

Yes, the method itself is guarded by sqlx-sqlite

ys928 commented 1 month ago

Oh, indeed, I was wrong, everything is fine.

github-actions[bot] commented 1 month ago

:tada: Released In 1.0.0-rc.5 :tada:

Thank you everyone for the contribution! This feature is now available in the latest release. Now is a good time to upgrade! Your participation is what makes us unique; your adoption is what drives us forward. You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.