search

SeaQL / sea-orm

🐚 An async & dynamic ORM for Rust
https://www.sea-ql.org/SeaORM/
Apache License 2.0
7.37k stars 517 forks source link

call `EnumIter::get` using fully qualified syntax #2321

Closed jcreekmore closed 1 month ago

jcreekmore commented 3 months ago

Bug Fixes

itertools version 0.13.0 added a get method that takes precedence over the EnumIter::get method. The EnumIter derive should be calling the method fully-qualified to ensure that the local version is called rather than the method that is provided by the Itertools trait. This was fixed in strum 0.26.x, but since this is a forked/adapted version of the EnumIter derive, it requires the same fix .

Expurple commented 3 months ago

Oh, so that's what has been preventing me from updating to itertools 0.13! Thank you.

jcreekmore commented 2 months ago

Is there something I am missing or need to do to get a review?

Expurple commented 2 months ago

For the last few months, maintainers pay very little attention to community issues/PRs :(

It's weird, given that they still release new versions, blog posts, etc. They're probably focusing on their own checklist for sea-orm 1.0 and then sea-orm 1.1.0 with sqlx 0.8, although it's hard to say for sure.

github-actions[bot] commented 1 month ago

:tada: Released In 1.1.0-rc.2 :tada:

Thank you everyone for the contribution! This feature is now available in the latest release. Now is a good time to upgrade! Your participation is what makes us unique; your adoption is what drives us forward. You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

github-actions[bot] commented 1 month ago

:tada: Released In 1.1.0 :tada:

Thank you everyone for the contribution! This feature is now available in the latest release. Now is a good time to upgrade! Your participation is what makes us unique; your adoption is what drives us forward. You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.