search

SeaQL / sea-query

🔱 A dynamic SQL query builder for MySQL, Postgres and SQLite
https://www.sea-ql.org
Other
1.18k stars 195 forks source link

feat: rust toolchain file #648

Closed EstebanBorai closed 1 year ago

EstebanBorai commented 1 year ago

Provides a Toolchain File to control Rust version to use, currently the file points to Nightly Latest.

This facilitates contributors when running commands like

cargo +nightly fmt

This is an update from: https://github.com/SeaQL/sea-query/pull/643

billy1624 commented 1 year ago

Thanks!! @EstebanBorai Interesting stuff. Basically, this config will force cargo fmt and cargo clippy to execute the respective component in nightly version.

REF: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

EstebanBorai commented 1 year ago

Thanks!! @EstebanBorai Interesting stuff. Basically, this config will force cargo fmt and cargo clippy to execute the respective component in nightly version.

REF: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

Yes!!

EstebanBorai commented 1 year ago

Thanks!! @EstebanBorai Interesting stuff. Basically, this config will force cargo fmt and cargo clippy to execute the respective component in nightly version.

REF: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

@billy1624 can we merge this?

EstebanBorai commented 1 year ago

@billy1624 can we merge this?

EstebanBorai commented 1 year ago

Oh! I think I closed this by accident! Im sorry! Do you guys think it would be useful to have? I could reopen if thats the case!

EstebanBorai commented 1 year ago

Reopening here: #698 @ikrivosheev! I think this is helpful and improves DevEx