search

SeaQL / sea-query

🔱 A dynamic SQL query builder for MySQL, Postgres and SQLite
https://www.sea-ql.org
Other
1.18k stars 195 forks source link

Diesel integration #658

Closed Sytten closed 1 year ago

Sytten commented 1 year ago

PR Info

See discussion: https://github.com/SeaQL/sea-query/discussions/168

BLOCKED BY https://github.com/diesel-rs/diesel/pull/3691 and https://github.com/diesel-rs/diesel/pull/3694

New Features

Sytten commented 1 year ago

@weiznich I would greatly appreciate if you could let me know if you think this is a good approach 🙏

Sytten commented 1 year ago

@tyt2y3 @billy1624 This is ready for a first review, we still have to wait for the next diesel release before we can merge though

Sytten commented 1 year ago

@tyt2y3 builds are failing because the bigdecimal versions dont match without a Cargo.lock, considering what I discussed in #664 are you OK with me adding a lock file to the examples and the crate?

tyt2y3 commented 1 year ago

considering what I discussed in #664 are you OK with me adding a lock file to the examples and the crate?

Sure, I am okay with it

Sytten commented 1 year ago

@tyt2y3 Ready for review

tyt2y3 commented 1 year ago

Released in https://crates.io/crates/sea-query-diesel/0.1.0

Sytten commented 1 year ago

Thanks much appreciated!