Closed mgmarlow closed 2 months ago
@tyt2y3 Wonder if this could get attention? We're working off of a fork and would rather get back onto a released version. Thanks!
yes sure, thanks for the nudge
Thank you everyone for the contribution! This feature is now available in the latest release. Now is a good time to upgrade! Your participation is what makes us unique; your adoption is what drives us forward. You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.
PR Info
Just like
#get_args
and#get_func
, make a getter formods
,#get_mods
, and makeFuncArgMod
public.We're using sea-query with a non-supported database (Hive). The QueryBuilder interface set up in sea-query is nicely designed such that we can extend it for our purposes, but it has a problem in that many of the internals used by similar QueryBuilder structs (e.g. sqlite, postgres) make use of private APIs. This means that while the path is clear for creating a custom query builder, doing so without maintaining a fork requires duplicating lots of code to create public interfaces for our project.
#get_mods
is one such interface that we need to writeDISTINCT
queries in our query builder.New Features
FunctionCall#get_mods
to getFuncArgMod
sBug Fixes
NA
Breaking Changes
NA
Changes
FuncArgMod
structFunctionCall#get_mods