search

SeaQL / sea-query

🔱 A dynamic SQL query builder for MySQL, Postgres and SQLite
https://www.sea-ql.org
Other
1.12k stars 182 forks source link

rusqlite - bundled forces static linkage #754

Closed majorfrog closed 6 months ago

majorfrog commented 6 months ago

Description

sea-query-rusqlite dependency rusqlite, states feature "bundled" which forces static linkage and automatically compile and link in an up to date version of SQLite.

It is not a default feature (for good reasons) and increases the binary size significantly.

It shopuld not be the default or it should be possible to state whether or not you want this behavior.

Expected Behavior

Should be possible to link against already present version of sqlite on the system.

Actual Behavior

Sqlite is built and statically linked.

Reproduces How Often

Always

Versions

sea-orm v0.12.10 sea-query v0.30.6

Additional Information

Dependency in sea-query-rusqlite/Cargo.toml

tyt2y3 commented 6 months ago

A PR would be appreciated to make it an optional feature.

tyt2y3 commented 6 months ago

Fixed in https://crates.io/crates/sea-query-rusqlite/0.6.0-rc.1