issues-721 Add impl `IdenStatic` and `AsRef<str>` to `#[enum_def]` attr

SeaQL / sea-query

🔱 A dynamic SQL query builder for MySQL, Postgres and SQLite

https://www.sea-ql.org

Other

1.12k stars 182 forks source link

issues-721 Add impl `IdenStatic` and `AsRef<str>` to `#[enum_def]` attr #769

Open AndreiOrmanji opened 4 months ago

AndreiOrmanji commented 4 months ago

PR Info

Closes https://github.com/SeaQL/sea-query/issues/721

New Features

[x] Copied #[enum_def] to sea-query-derive (and marked #[enum_def] as deprecated at sea-query-attr)
[x] Added impl IdenStatic to #[enum_def] of sea-query-derive
[x] Added impl AsRef<str> to #[enum_def] of sea-query-derive
[x] Updated syn crate from (1 -> 2) (by merging #799, created by @sandhose)
[x] Updated heck crate from (0.4 -> 0.5) (by merging #799, created by @sandhose)
[x] Updated darling crate from (0.14 -> 0.20) (by merging #799, created by @sandhose)

tyt2y3 commented 4 months ago

Hi, as I said in another comment, for long term maintenance I would like to deprecate sea-query-attr and move the macro into sea-query-derive. However, we'll have to migrate to syn2 and probably rename a few things. Would you like to do that?

AndreiOrmanji commented 4 months ago

Hi, as I said in another comment, for long term maintenance I would like to deprecate sea-query-attr and move the macro into sea-query-derive. However, we'll have to migrate to syn2 and probably rename a few things. Would you like to do that?

I've done it in d75bf0a. I'm not sure if I've marked as deprecated correctly, and that's why I did not update CHANGELOG.md and README.md to reflect my changes there.

AndreiOrmanji commented 4 weeks ago

I was looking at upgrading syn/darling in sea-query-attr, and did not see your PR first.

So, I still opened a draft PR for visibility: #799

@sandhose, Can I merge your branch with mine as part of this MR?

sandhose commented 4 weeks ago

I was looking at upgrading syn/darling in sea-query-attr, and did not see your PR first.

So, I still opened a draft PR for visibility: #799

@sandhose,

Can I merge your branch with mine as part of this MR?

Of course, take whatever you need from that PR