SeaQL / sea-query

🔱 A dynamic SQL query builder for MySQL, Postgres and SQLite
https://www.sea-ql.org
Other
1.12k stars 182 forks source link

sea-query-binder has time version `<0.3.35` #772

Closed jeremychone closed 4 months ago

jeremychone commented 4 months ago

Description

In sea-query-binder version 0.6.0-rc.2,

in sea-query-binder, the time crate version is set as <0.3.35 (i.e., time = { version = "<0.3.35",...}).

Is there any reason for this?

It does cause some understandably unforeseen behavior when the lib/app code relies on 0.3. It seems to work, but tools like cargo outdated completely break for example, and might have other side effects.

Steps to Reproduce

  1. Have sea-query with sea-query-binder with time
  2. have another time = "0.3' in the Cargo.toml
  3. cargo install cargo-outdated and then cargo outdated. The issue is that if this break, there might be more side effecs.

Expected Behavior

time set to version 0.3 or 0.3.35.

Actual Behavior

time set to version <0.3.35.

Versions

In sea-query-binder version 0.6.0-rc.2,

tyt2y3 commented 4 months ago

See https://github.com/SeaQL/sea-query/pull/766