search

SeaUrchinBot / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

Ratings inDocument_ property never set to true #546

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

What steps will reproduce the problem?
1. visit 
http://closure-library.googlecode.com/svn/trunk/closure/goog/demos/ratings.html
2. enter rw1.isInDocument() in dev tools console, see output.

What is the expected output? What do you see instead?
Expected true, since the component is in the document. Output is false.

What version of the product are you using? On what operating system?
At revision: 2519, Windows 7

Please provide any additional information below.
Components enterDocument is overridden for rating without calling base 
implementation.

Note: we cannot accept patches without the contributor license agreement
being signed. See http://code.google.com/p/closure-
library/wiki/Contributors for more info.

Original issue reported on code.google.com by byron.st...@pixell.de on 14 Mar 2013 at 9:44

GoogleCodeExporter commented 9 years ago 
This was being caused by a missing super class call. Follow the github issue as 
a fix should be out soon: https://github.com/google/closure-library/issues/65

Original comment by joelt...@google.com on 18 Aug 2015 at 11:49