search

Seaal / Pug

A Client for Jedi Knight Academy pick up games
GNU Affero General Public License v3.0
2 stars 0 forks source link

Wrap ngx-translate in a TranslateService #21

Closed Seaal closed 6 years ago

Seaal commented 7 years ago

Abstract the use of ngx-translate, so it can be replaced easily if needed.

Seaal commented 7 years ago

Need to create a new localize pipe instead of using the translate pipe directly

Seaal commented 7 years ago

Could export ngx-translate in the common module, so it doesn't need to be imported elsewhere. Rewriting the translate pipe seems like a waste, could try subclassing existing implementation to change the name of the pipe or alternatively just take a dependency on translate as the pipe name for localization.