SeabertYuan / better-workday-calendar

MIT License
4 stars 1 forks source link

feat: update URL check function to include new target page #2

Closed p0ryae closed 2 months ago

p0ryae commented 2 months ago

Currently, it isn't possible for this extension to be activated when opening the calendar by navigating through: My Profile -> Academics -> Current Classes -> Calendar view. This PR aims to include a new page in the checksum for this particular way of viewing the calendar.

SeabertYuan commented 2 months ago

Thank you for catching this!

p0ryae commented 2 months ago

Hey @SeabertYuan, I noticed the recent URL change in your commit seems to cause an issue for me. It looks like the numbers after the $ might be user-specific. It might be better to remove the dependency on them altogether (aka. just put the following: wd10.myworkday.com/ubc/d/inst/1$37/10089).

SeabertYuan commented 2 months ago

I suspect that you're right I will make this change.