Seagate / cortx-ha

CORTX ha (High-Availability) is responsible for ensuring that CORTX Solution is available in case of any hardware component or software service failures. It takes care of failover/ failback control flow for affected services and stabilizes them across CORTX cluster.
https://github.com/Seagate/cortx
GNU Affero General Public License v3.0
4 stars 45 forks source link

CORTX-30931: Implement REST API helper functionality and HTTP error code framework #700

Closed akash2144 closed 9 months ago

akash2144 commented 2 years ago

Signed-off-by: Akash Dudhane akash.a.dudhane@seagate.com

Problem Statement

Design

Testing

Review Checklist

Review Checklist

Documentation

Checklist for Author

akash2144 commented 2 years ago

PR contains some changes from PR #696. Once that PR is merged will rebase this PR.

Most of the codacy issues are in conflict , One of them should be disabled. Ex. D203: 1 blank line required before class docstring D211: No blank lines allowed before class docstring

akash2144 commented 2 years ago

Do we have separate ticket for covering unittests? @akash2144

@mariyappanp Currently no API is available for testing, Once API is available will write test case there. CORTX-30029

mariyappanp commented 2 years ago

It would be better to maintain rest api framework if we separate it from ha service like ha/framework/restapi. What do you think, @akash2144 @shaileshsvc @ArchanaLimaye

stale[bot] commented 2 years ago

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @shaileshsvc @ArchanaLimaye for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

stale[bot] commented 2 years ago

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @shaileshsvc @ArchanaLimaye for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

hessio commented 2 years ago

Is this PR still relevant? If not, can we close it?

stale[bot] commented 2 years ago

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @shaileshsvc @ArchanaLimaye for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

shailesh-vaidya commented 9 months ago

Closing as an obsolete