CORTX-32157: Refactor client Chart values - Githubissues

Seagate / cortx-k8s

CORTX Kubernetes Orchestration Repository

https://github.com/Seagate/cortx

Apache License 2.0

6 stars 47 forks source link

CORTX-32157: Refactor client Chart values #314

Closed keithpine closed 2 years ago

keithpine commented 2 years ago

Description

Refactor the Chart values for the (Motr) client component.

Remove redundant "cortx" prefix
Use camelcase to match Helm conventions
Convert image into an object. Tag is undefined and will default to the Chart AppVersion value.
Default to the real CORTX client image, instead of centos.
Allow imagePullPolicy to be configurable

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[X] New feature (non-breaking change that adds new functionality)
[ ] Breaking change (bug fix or new feature that breaks existing functionality)
[ ] Third-party dependency update
[ ] Documentation additions or improvements
[ ] Code quality improvements to existing code or test additions/updates

Applicable issues

This change fixes an issue: CORTX-32157
This change is related to an issue: #

How was this tested?

Deployed cluster, with and without Client enabled. Ran m0 client in container.

Ran helm template and saw default values, like the image, being correctly configured.

Checklist

[x] The change is tested and works locally.
[ ] New or changed settings in the solution YAML are documented clearly in the README.md file.
[x] All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change requires newer CORTX or third party image versions:

[ ] The image fields in solution.example.yaml have been updated to use the required versions.
[ ] The appVersion field of the Helm chart has been updated to use the new CORTX version.

If this change addresses a CORTX Jira issue:

[x] The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)