Seagate / cortx-prvsnr

CORTX Provisioner offers a framework which accepts configurations (cluster.yaml and config.yaml) in the form of ConfigMap, translates into internal configuration (CORTX Conf Store) and then orchestrates across components mini provisioners to allow them to configure services. In Kubernetes environment, CORTX Provisioner framework runs on all the CORTX PODs (in a separate one time init container).

https://github.com/Seagate/cortx

GNU Affero General Public License v3.0

17 stars 40 forks source link

Cortx 30254: Codacy issues fix #6369

Closed lakshita-jain closed 2 years ago

lakshita-jain commented 2 years ago

Problem Statement

Codacy fix in two shell scripts (i.e. /jenkins/docker/build.sh & jenkins/build.sh)

Design

For Bug, Describe the fix here.
For Feature, Post the link for design

Coding

Checklist for Author

[x] Coding conventions are followed and code is consistent

Testing

Checklist for Author

[x] Unit and System Tests are added
[x] Test Cases cover Happy Path, Non-Happy Path and Scalability
[x] Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

[x] Interface change (if any) are documented
[ ] Side effects on other features (deployment/upgrade)
[ ] Dependencies on other component(s)

Review Checklist

Checklist for Author

[x] JIRA number/GitHub Issue added to PR
[x] PR is self reviewed
[x] Jira and state/status is updated and JIRA is updated with PR link
[x] Check if the description is clear and explained

Documentation

Checklist for Author

[x] Changes done to WIKI / Confluence page / Quick Start Guide

cortx-admin commented 2 years ago

Can one of the admins verify this patch?

lakshita-jain commented 2 years ago

Retest this Please

lakshita-jain commented 2 years ago

Retest this please

gauravchaudhari02 commented 2 years ago

retest this please

lakshita-jain commented 2 years ago

3 N deployment successful: https://eos-jenkins.colo.seagate.com/job/Provisioner/job/N-Node_CORTX_Deployment_on_K8s_Cluster/223/console