Seagate / cortx-re

CORTX Release Engineering Scripts and Dockerfiles.

https://github.com/Seagate/cortx

GNU Affero General Public License v3.0

5 stars 52 forks source link

CORTX-32962 : Update community build script for tag support #1161

Closed gauravchaudhari02 closed 2 years ago

gauravchaudhari02 commented 2 years ago

Problem Statement

community build script was not tested with tag based component repositories checkout

Design

Update and test community build script with tag based checkout

Coding

Checklist for Author

[x] Coding conventions are followed and code is consistent

Testing

Checklist for Author

[ ] Unit and System Tests are added
[x] Test Cases cover Happy Path, Non-Happy Path and Scalability
[ ] Testing was performed with RPM
[x] Jenkins pipelines used for testing - Tested locally by running cortx-build.sh script

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

[ ] Interface change (if any) are documented
[ ] Side effects on other features (deployment/upgrade)
[ ] Dependencies on other component(s)

Review Checklist

Checklist for Author

[x] JIRA number/GitHub Issue added to PR
[x] PR is self reviewed
[x] Jira and state/status is updated and JIRA is updated with PR link
[x] Check if the description is clear and explained

Documentation

Checklist for Author

[x] Changes done to WIKI / Confluence page / Quick Start Guide

View rendered solutions/community-deploy/CORTX-Deployment.md

gauravchaudhari02 commented 2 years ago

Looks good. Please test script manually once and add details to PR

Tested image generation and deployment manually. its working fine