Seagate / cortx-re

CORTX Release Engineering Scripts and Dockerfiles.

https://github.com/Seagate/cortx

GNU Affero General Public License v3.0

5 stars 52 forks source link

CORTX-33942: Improve GitHash fetch in changelog generation script #1176

Closed gauravchaudhari02 closed 2 years ago

gauravchaudhari02 commented 2 years ago

Problem Statement

GitHub API not able to fetch PR details with short commit hashes API - https://api.github.com/repos///commits//pulls
Design
Added --abbrev=10 for including 10 characters in commit hash which works fine with API.

Coding

Checklist for Author

[x] Coding conventions are followed and code is consistent

Testing

Checklist for Author

[ ] Unit and System Tests are added
[x] Test Cases cover Happy Path, Non-Happy Path and Scalability
[ ] Testing was performed with RPM
[x] Jenkins pipelines used for testing - https://eos-jenkins.colo.seagate.com/job/Release_Engineering/job/Cortx-Automation/job/changelog-generation/640/artifact/CHANGESET.md/*view*/

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

[ ] Interface change (if any) are documented
[ ] Side effects on other features (deployment/upgrade)
[ ] Dependencies on other component(s)

Review Checklist

Checklist for Author

[x] JIRA number/GitHub Issue added to PR
[x] PR is self reviewed
[x] Jira and state/status is updated and JIRA is updated with PR link
[x] Check if the description is clear and explained

Documentation

Checklist for Author

[ ] Changes done to WIKI / Confluence page / Quick Start Guide