Seagate / cortx-re

CORTX Release Engineering Scripts and Dockerfiles.
https://github.com/Seagate/cortx
GNU Affero General Public License v3.0
5 stars 52 forks source link

CORTX-34145: Reduce CORTX container build time #1220

Closed shailesh-vaidya closed 2 years ago

shailesh-vaidya commented 2 years ago

Problem Statement

Design

Coding

Checklist for Author

Testing

Checklist for Author

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

Review Checklist

Checklist for Author

Documentation

Checklist for Author

gauravchaudhari02 commented 2 years ago

@shailesh-vaidya, PR looks good. but as we are removing cortx-all reference, can we remove these variables as well? https://github.com/Seagate/cortx-re/search?p=2&q=env.cortx_all_image

shailesh-vaidya commented 2 years ago

@shailesh-vaidya, PR looks good. but as we are removing cortx-all reference, can we remove these variables as well? https://github.com/Seagate/cortx-re/search?p=2&q=env.cortx_all_image

Sure. I will update the variable name to env.cortx_images

shailesh-vaidya commented 2 years ago

@shailesh-vaidya, PR looks good. but as we are removing cortx-all reference, can we remove these variables as well? https://github.com/Seagate/cortx-re/search?p=2&q=env.cortx_all_image

Sure. I will update the variable name to env.cortx_images

@gauravchaudhari02 - Fixed reference from the generic folder. I will raise a separate PR to remove all centos-7.9.2009 and centos-7.8.2003 folders as they are not in use now.

shailesh-vaidya commented 2 years ago

@shailesh-vaidya, PR looks good. but as we are removing cortx-all reference, can we remove these variables as well? https://github.com/Seagate/cortx-re/search?p=2&q=env.cortx_all_image

Sure. I will update the variable name to env.cortx_images

@gauravchaudhari02 - Fixed reference from the generic folder. I will raise a separate PR to remove all centos-7.9.2009 and centos-7.8.2003 folders as they are not in use now.

@gauravchaudhari02 - Raised https://github.com/Seagate/cortx-re/pull/1223 to remove old code.

gauravchaudhari02 commented 2 years ago

@shailesh-vaidya, can we rename this variable as well? https://github.com/Seagate/cortx-re/blob/9a933717d8419a46191c510d4c37178e9bf44bce/jenkins/custom-ci/generic/custom-ci.groovy#L502 https://github.com/Seagate/cortx-re/blob/9a933717d8419a46191c510d4c37178e9bf44bce/jenkins/custom-ci/generic/custom-ci.groovy#L491 https://github.com/Seagate/cortx-re/blob/9a933717d8419a46191c510d4c37178e9bf44bce/jenkins/custom-ci/generic/custom-ci.groovy#L519 and check running custom-ci with mail template?

shailesh-vaidya commented 2 years ago

@shailesh-vaidya, can we rename this variable as well?

https://github.com/Seagate/cortx-re/blob/9a933717d8419a46191c510d4c37178e9bf44bce/jenkins/custom-ci/generic/custom-ci.groovy#L502

https://github.com/Seagate/cortx-re/blob/9a933717d8419a46191c510d4c37178e9bf44bce/jenkins/custom-ci/generic/custom-ci.groovy#L491

https://github.com/Seagate/cortx-re/blob/9a933717d8419a46191c510d4c37178e9bf44bce/jenkins/custom-ci/generic/custom-ci.groovy#L519

and check running custom-ci with mail template?

@gauravchaudhari02 - Addressed review comments and tested in https://eos-jenkins.colo.seagate.com/job/GitHub-custom-ci-builds/job/generic/job/custom-ci/7813/console