pankajgborole commented 1 year ago

Problem Statement

Fix to update the secret id and key as variable

Describe your changes in brief

During GitHub scan, it reported Possible valid secrets found in repository in form of AWS ID and key Its decided to hide these secrets and update the actual values with v_key_name There is no impact to any functional aspects as mainly its used as S3 client and not actually being used. whenever actual AWS Account is used its not active accounts. for safely reason we are replace all such instances as well.

Changes

[*] Why is this change required? What problem does it solve? Fix for secret warnings reported by GitHub
[ ] If proposing a new change then please raise an issue first

How Has This Been Tested? (Optional)

[ ] Please describe in detail how you tested your changes.
[ ] Include details of your testing environment, and the tests you ran to
[ ] How your change affects other areas of the code, etc.

Screenshots (if appropriate)

Checklist

[ ] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test Testing is not in scope as the accounts are not active and test are not being executed recently

welcome[bot] commented 1 year ago

Thanks for your contribution in opening this pull request! Now you can be rewarded with a CORTX sticker by requesting cortx sticker In the meantime, please check out the contributing guidelines and explore other ways you can get involved.