1468ca0b-2a64-4fb4-8e52-ea5806644b4c
commented
6 years ago Created by: andriytk
The performance regression could be caused by the fact that the messages are not taken out of the cep buffer when guard is not passing. Which means that the same messages will be checked again and again many times.
extractMatchMsg :: Serializable a
=> (a -> g -> l -> Process (Maybe b))
-> l
-> Buffer
-> State.StateT g Process (Maybe (Extraction b))
extractMatchMsg p l buf = go (-1)
where
go lastIdx =
case bufferGetWithIndex lastIdx buf of
Just (newIdx, a, newBuf) -> do
res <- State.get >>= \g -> lift (Catch.mask_ $ trySome $ p a g l)
case res of
Left _ -> return Nothing
Right Nothing -> go newIdx -- HERE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Right (Just b) ->
let ext = Extraction
{ _extractBuf = newBuf
, _extractMsg = b
, _extractIndex = newIdx
}
in return $ Just ext
_ -> return Nothing
trySome :: Process a -> Process (Either Catch.SomeException a)
trySome = Catch.try
Created by: andriytk
Implemented phase switching guard for notifier which checks whether graph change notification confirmation is the one it is waiting for. This allows to avoid notifier odd phase switches, especially on a large cluster configurations when there may be a large number of notifier instances waiting for their notification confirmations.