Seagate / halon

High availability solution

Apache License 2.0

1 stars 0 forks source link

HA.Resources.Mero: Disk-[Is]->Replaced is a 1:1 relationship #1475

Closed 1468ca0b-2a64-4fb4-8e52-ea5806644b4c closed 6 years ago

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

Several Replaced markers for the same Disk make no sense.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

1483

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

Ok, I will.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

Okay. This might also let us find all disks marked as replaced with G.connectedFrom Is M0.Replaced rg.

Would you care to post a pull request?

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

Well, it may save some space in RG. Especially on big cluster configurations with long disk replacement history.

You can view this as one to many relations in relational database. Many disks may have the same property. Properties are in one table and disks in another with the property_id reference in properties table for each disk.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

Maybe. What difference will it make from the usage perspective?

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

Many disks can be replaced. Wouldn't it be better to make it like this:

  , (''Disk, Unbounded, ''Cas.Is, AtMostOne, ''Replaced)