Seagate / halon

High availability solution
Apache License 2.0
1 stars 0 forks source link

HALON-798: fix Clovis-app falure handling on startup #1491

Closed 1468ca0b-2a64-4fb4-8e52-ea5806644b4c closed 6 years ago

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

Ok, will do. I don't mind. :)

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

Well, I like it like this also. :)

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

Ah, so the type signature was needed after all. I apologize for causing confusion.

[optional] Now that we know that :: String is required, the original code would look better.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

Why ‘do’? Transition to. s/do/to/, if you don't mind.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

Right. Done.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

Ok, done.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

Ok, done.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: andriytk

So that the process transition to Unknown state would affect its services as well. This will allow to avoid the situations like this:

  [      N/A] 0x7200000000000001:0x26     192.168.180.162@tcp:12345:41:302 clovis-app
  [ Starting] 0x7300000000000001:0x27       CST_RMS
1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

Why is this needed?

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

s/tmo/toPSFailed/, please.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

[optional] Consider inlining the printf expression and getting rid of msg:

        Log.rcLog' Log.DEBUG $
            printf "Requesting start of %s (%s)" (showFid p) (show runType)
1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

[optional] Type signature is noisy here.

1468ca0b-2a64-4fb4-8e52-ea5806644b4c commented 6 years ago

Created by: vvv

[optional,nit] Consider using if expression.

              onSuccess $ if G.isConnected p Is M0.ProcessBootstrapped rg
                          then start_process
                          else configure