Seagate / halon

High availability solution
Apache License 2.0
1 stars 0 forks source link

HALON-889: lts-11.22 update #1534

Closed andriytk closed 5 years ago

andriytk commented 5 years ago

lts-11 + ghc-8.2 might allow us to build Halon on arm64!

Note: the stack supports arm64 since 1.7.1 version and starting with ghc-8.2.2.

chumakd commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

marked as a Work In Progress

andriytk commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

changed this line in version 22 of the diff

andriytk commented 5 years ago

resolved all discussions

andriytk commented 5 years ago

added 1 commit

Compare with previous version

chumakd commented 5 years ago

Suggestion: add a comment above this line, giving a short explanation (not needed to repeat full commit msg though).

andriytk commented 5 years ago

added 5 commits

Compare with previous version

vvv commented 5 years ago

enabled an automatic merge when the pipeline for 12d3fee5ca56dee8487bae433045cfc5d5633672 succeeds

andriytk commented 5 years ago

added 6 commits

Compare with previous version

vvv commented 5 years ago

unmarked as a Work In Progress

andriytk commented 5 years ago

added 8 commits

Compare with previous version

vvv commented 5 years ago

resolved all discussions

vvv commented 5 years ago

Rebased.

vvv commented 5 years ago

added 17 commits

Compare with previous version

vvv commented 5 years ago

@andriy.tkachuk I propose to rebase this branch onto master after #1538 is landed.

chumakd commented 5 years ago

added 3 commits

Compare with previous version

chumakd commented 5 years ago

added 3 commits

Compare with previous version

andriytk commented 5 years ago

added 1 commit

Compare with previous version

chumakd commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

added 1 commit

Compare with previous version

vvv commented 5 years ago

marked as a Work In Progress from 05fbb06ea7e501055dac9b6ff23d08f96213355e

vvv commented 5 years ago

added 1 commit

Compare with previous version

chumakd commented 5 years ago

added 1 commit

Compare with previous version

vvv commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

added 2 commits

Compare with previous version

vvv commented 5 years ago

changed the description

vvv commented 5 years ago

unmarked as a Work In Progress

andriytk commented 5 years ago

resolved all discussions

chumakd commented 5 years ago

added 4 commits

Compare with previous version

andriytk commented 5 years ago

Fixed.

andriytk commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

changed this line in version 6 of the diff

vvv commented 5 years ago

added 1 commit

Compare with previous version

vvv commented 5 years ago

added 1 commit

Compare with previous version

andriytk commented 5 years ago

Well, it might be also a kind of specification by which one could easily determine with which package versions we are supposed to work. Speaking of which, the lower range should be updated as well everywhere probably...

vvv commented 5 years ago

OK. Thanks.

vvv commented 5 years ago

see the history of versions halon was compiled with

git log -p -- stack.yaml would provide less convoluted way to do that.

I'd prefer to follow the pattern for now.

Which pattern? Do you see any principle of version constraints specifications?

andriytk commented 5 years ago

By having this range of version we at least can see the history of versions halon was compiled with. Maybe there is some other reason, like more control over the versions, don't know. But I'd prefer to follow the pattern for now.

andriytk commented 5 years ago

There are not so much of them to bother.

andriytk commented 5 years ago

It helps to avoid confusion with data type `a'.

andriytk commented 5 years ago

marked as a Work In Progress from ad1bc818a1d1153d13c6943588982953f66f1af8

andriytk commented 5 years ago

added 3 commits

Compare with previous version

andriytk commented 5 years ago

changed this line in version 3 of the diff

andriytk commented 5 years ago

changed this line in version 3 of the diff

andriytk commented 5 years ago

changed this line in version 3 of the diff

andriytk commented 5 years ago

Well, it won't compile with ghc-8.2 without it. If you are asking about ghc-heap-view - some debugging tool? I think we use it when printing some status on halond exit.