scripts/h0: fix cmd_install on vagrant singlenode

[andriytk]

On vagrant setup with bridge interface the cmd_install was selecting the wrong interface and, as result, wrong IP address for HALOND_LISTEN parameter on the singlenode configuration.

Now we just select eth1 interface (if present) which is the default interface on vagrant setup. Otherwise, we allow scripts/install-halon-services to select the interface.

[andriytk]

resolved all discussions

[chumakd]

merged

[chumakd]

enabled an automatic merge when the pipeline for 08f27e925bb5b87412074b7104b4461878bdeb21 succeeds

[andriytk]

added 1 commit

• 08f27e92 - scripts/h0: fix cmd_install on vagrant singlenode

Compare with previous version

[andriytk]

changed this line in version 2 of the diff

[andriytk]

I think it is better than nothing.

[chumakd]

@andriy.tkachuk you'll get something like this among "normal" h0 logs output:

ls: cannot access /sys/class/net/: No such file or directory

which will look out of context - but if you think it will help identify an issue, we can keep it.

[andriytk]

@dmitriy.chumak style - ok. About the error - not sure we don't want to see it... Do we really?

[andriytk]

Not sure it is needed.

[chumakd]

assigned to @andriy.tkachuk

[38f17114-d02a-4404-a14d-847256ffc365]

@andriy.tkachuk Do we need to check operate state of eth1? if it is required then I guess ethtool can be used to check link status else LGTM.

[38f17114-d02a-4404-a14d-847256ffc365]

resolved all discussions

[chumakd]

Please follow the style already established in the h0 script to run external commands, i.e. use $(...) construct instead of backticks.

Also, redirecting stderr from ls to /dev/null can help avoiding extra noise in situations when /sys/ is not mounted.

[andriytk]

assigned to @prasanna.kulkarni

[andriytk]

@prasanna.kulkarni, @dmitriy.chumak could you review this, please?