scripts/h0 (cmd_install, cmd_uninstall): nitpicking

Seagate / halon

High availability solution

Apache License 2.0

1 stars 0 forks source link

scripts/h0 (cmd_install, cmd_uninstall): nitpicking #1565

Closed vvv closed 5 years ago

vvv commented 5 years ago

Run precise check (test -e eth1) instead of matching against a pattern (ls | grep eth1).
CMD && ACTION may return non-zero exit code. This would prevent execution of subsequent commands, since h0 script runs with set -e. The solution is to either use if CMD; then ACTION; fi or ! CMD || ACTION.

chumakd commented 5 years ago

merged

andriytk commented 5 years ago

resolved all discussions

andriytk commented 5 years ago

Ok, it seems working on my devvm (just checked).

chumakd commented 5 years ago

@andriy.tkachuk I believe it will work the same way, bash will strip away the empty string variable substitution

andriytk commented 5 years ago

I'm not sure it will work in case there is no eth1 interface. Please check it on devvm. (The old approach with ${var:+} made argument void to the script if the var is null. Now it will be just an empty string instead.)