Closed mssawant closed 5 years ago
closed
This merge request has been obsoleted by http://gitlab.mero.colo.seagate.com/mero/halon/merge_requests/1573. It may be reopened if necessary.
I can try first option. Regarding second option, I think the main idea to have drives attached to specific services (ios, be, addb) in facts file is for Halon to distinguish between multiple storage services on the same node. Because we cannot have multiple hostnames for the same physical node which relates to m0_fqdn, I though we should be able to specify multiple storage roles for the same physical node or for the same m0_fqdn. With my earlier format proposal, we can add multiple storage entries with corresponding devices for the same.
added 1 commit
Currently a “role” is merely a reference to roles file entry. Simple. Putting services and devices information into a role descriptor complicates the format. This complication is avoidable:
m0h_services
) at the top of server descriptor. No changes in roles processing are required.id_m0_servers/%/m0h_devices/%/service_type
field (supported values: "ios", "be", "addb"). The facts file format remains pretty much the same in this case, required amount of code changes is minimal.When deciding which approach to choose, we should also take the effort of m0genfacts
modification into consideration.
@mandar.sawant I've added a draft of the RFC — rfc/026-XXX.md
. If we agree that such document is needed, we should rename the file and take care of the sections marked with "XXX".
The source branch is 70 commits behind the target branch
$ git log --oneline origin/Halon-894..origin/master | wc -l 70
The branch is quite old. Why?